E2E tests: Return original content if edited content is unavailable ( siteEditor.getEditedPostContent() ) #30916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
reviewed
Apr 16, 2021
|
Size Change: +2.18 kB (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
Addison-Stavlo and
creativecoder
david-szabo97
changed the title
|
Superseded by #31121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason the object returned by
getEditedEntityRecordsometimes contain an emptycontentproperty. To make sure we always have something returned, we fallback to the original content.This should improve the consistency of the tests that are using this function.
How has this been tested?
Make sure tests are passing
Apply #30804 and make sure tests are passing.
Types of changes
Improve E2E tests consistency
Checklist:
*.native.jsfiles for terms that need renaming or removal).