[Fix] Inlined core block styles should not override user-added inline styles #31268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Bug
aristath
changed the title
gziolo
approved these changes
Apr 28, 2021
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an FSE theme, block styles may get inlined (depending on their size).
However, there is currently an issue and if a theme (or plugin) adds styles to these core block-styles using
wp_add_inline_style, the core block styles are appended to the ones that were added, overriding them if the same selectors are used.This PR changes the previous behavior and instead of adding the core block styles as the last item in the array, it adds them as the 1st item - therefore eliminating the problem.
How has this been tested?
Tested in combination with #31239 which adds
themestyles usingwp_add_inline_style.You can also test by adding something like this in an FSE theme:
Prior to this PR, the padding does not apply because it gets overridden by core styles. After this PR, the padding gets properly appried.
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).