Also rebuild block-specific styles in dev mode #31274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdwijngaert
added
[Type] Bug
aristath
previously requested changes
Apr 28, 2021
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Thanks so much for working on this, I can't tell you what a quality of life fix this will be. I'll defer to Ari for the code review, but just in testing, this works well for me:
Before reload:
After reload:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where edits to block specific styles in the
block-librarypackage did not result in the actual rebuilding of the block styles themselves. Only files matchingpackages/block-library/src/*.scsswere built.