components: Promote Heading #31299
Merged
components: Promote Heading #31299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +198 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Apr 29, 2021
gziolo
reviewed
Apr 29, 2021
|
I see a few PRs that expose G2 components as experimental. A few things to think about:
|
👍 What did you have in mind here? Are there specific things we should be looking for?
We didn't previously call out experimental components as experimental in Storybook (see
Yes we should keep them experimental for now until we've migrated more of them and confirmed that the implementations and props are what we want. Heading is simple enough that I don't think it needs to be experimental but it implements all of Text which is experimental and wide ranging (has truncation, highlighting, etc). I think the components are relatively stable but it'd be good for more people to review them so we can continue iterating on them.
I think the hooks are good for internal library composability but not necessary for things outside the library. What do you think? /cc @youknowriad |
sarayourfriend
force-pushed
the
add/upgrade-text
branch
from
820abc3 to
195be4a
Compare
|
My thinking right now is that we should hold a little bit before making things stable (after feature freeze for WP 5.8 which is something like May 19th in the Gutenberg repo) and after that date, I believe we should be more liberal about stabilizing components (and ideally use them in our codebase) cause we'll have time to adapt in case we discover anything weird (until WP 5.9) |
|
Good point @youknowriad about WP 5.8 ❤️ |
gziolo
force-pushed
the
add/promote-heading
branch
from
db9f967 to
1ec95a5
Compare
sarayourfriend
requested review from
cameronvoell,
ellatrix,
guarani,
nerrad,
noahtallen,
oandregal,
ntwb,
spacedmonkey and
TimothyBJacobs
gziolo
force-pushed
the
add/upgrade-text
branch
2 times, most recently
from
d1f1fe1 to
3d9ae4e
Compare
gziolo
force-pushed
the
add/promote-heading
branch
from
1ec95a5 to
8e21381
Compare
|
I applied changes myself and rebase the branch with I applied some additional changes:
See 8e21381. This is how this component looks in Storybook:
|
gziolo
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promotes the
Headingcomponent to a fullcomponentsexport.How has this been tested?
Storybook still works. The export is experimental and unused so there's no where else to test it.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).