Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: fix <Divider /> imports #31649

Closed
wants to merge 1 commit into from
Closed

Storybook: fix <Divider /> imports #31649

wants to merge 1 commit into from

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented May 10, 2021

Description

Fixes the import path for the <Divider /> component, which is preventing Storybook from building and running locally.

This bug was probably introduced in #31556

How has this been tested?

  1. On trunk, run npm run storybook:dev and notice the error printed in the console about the missing divider component
  2. Repeat on this branch, and notice how the command runs fine

Screenshots

N/A

Types of changes

Fix (import paths)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • N/A My code follows the accessibility standards.
  • N/A I've tested my changes with keyboard and screen readers.
  • N/A My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • N/A I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@stokesman
Copy link
Contributor

Nicely spotted 👍 You were first I think, but this got hot-fixed in 5f1a21c.

@ciampo
Copy link
Contributor Author

ciampo commented May 10, 2021

Nicely spotted 👍 You were first I think, but this got hot-fixed in 5f1a21c.

Got it, thank you! In that case, I'll close this PR

@ciampo ciampo closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants