-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add space to the Post Schedule date #3188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good idea, but I think the styling should be applied to children of components-panel__row
generally, not specific to the schedule toggle.
https://github.com/WordPress/gutenberg/blob/master/components/panel/style.scss
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 31.61% 31.17% -0.45%
==========================================
Files 217 235 +18
Lines 6278 6534 +256
Branches 1116 1163 +47
==========================================
+ Hits 1985 2037 +52
- Misses 3609 3773 +164
- Partials 684 724 +40
Continue to review full report at Codecov.
|
@aduth You are right, thats a better idea. I added the styling to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some issues with the labeling changes (which I'd also have recommended to create a separate pull request for):
- With component patterns as in React, we don't want to assume that there is a single instance of an element on a page, and since
id
must be globally unique,'post-visibility-selector'
is not a good ID. For these cases we created thewithInstanceId
higher-order component to generate unique IDs to use as suffixes. - Since Dropdown expects the developer to implement
renderToggle
with a button, we don't need it to accept anid
prop and rather can apply theid
on the button returned inrenderToggle
(inPostSchedule
and inPostVisibility
).
I created a separate pull request for the labels: #3317, so this one has to be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Description
Adds space between Post Schedule label and date
Resolve #3138
Screenshots:
Before:
After: