Card: delete old version of the g2 implementation #32764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
ciampo
requested review from
youknowriad,
gziolo,
diegohaz,
tyxla and
sarayourfriend
This was referenced Jun 17, 2021
ciampo
force-pushed
the
feat/components-card-promote
branch
from
5705bfc to
6c2cbd9
Compare
ciampo
force-pushed
the
feat/components-card-delete-old-g2
branch
from
c903335 to
c3f8635
Compare
|
Size Change: -52 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/components-card-delete-old-g2
branch
2 times, most recently
from
8c56d15 to
d82894e
Compare
ciampo
force-pushed
the
feat/components-card-promote
branch
from
6c2cbd9 to
5bd2875
Compare
ciampo
force-pushed
the
feat/components-card-delete-old-g2
branch
from
d82894e to
d65138b
Compare
ciampo
requested review from
tyxla and
sarayourfriend
and removed request for
tyxla and
sarayourfriend
sarayourfriend
approved these changes
Jun 22, 2021
ciampo
force-pushed
the
feat/components-card-delete-old-g2
branch
from
d65138b to
bce6e45
Compare
ciampo
force-pushed
the
feat/components-card-delete-old-g2
branch
from
bce6e45 to
9089891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of PRs with the final goal of achieving the same result as #32243 in smaller (and easier to review) steps.
Requires #32566
This PR deletes the g2 implementation of
<Card />that sits in thepackages/components/src/ui/cardfolder, since (with #32566) it is not needed anymore.Testing instructions
npm run storybook:dev)Screenshots
N/A
Types of changes
Clean up old code
Checklist:
*.native.jsfiles for terms that need renaming or removal).