-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test block insertion after title post blur #32944
Conversation
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
I need to test accessibility interactions before this PR is ready for review. It is quite possible that the current changes in the PR have broken/worsened audible descriptions for accessibility. |
packages/edit-post/src/components/visual-editor/test/index.native.js
Outdated
Show resolved
Hide resolved
I see that the PR has some conflicts, they're caused due to this PR got merged. Probably just updating it with |
05c543d
to
0cbf61d
Compare
Relates to #32831. Adds tests asserting that block inserter inserts new blocks in the correct position after blurring the post title field.
0cbf61d
to
95a8eaa
Compare
@fluiddot these tests are ready for re-review. Please feel free to merge or close this PR as you see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 ! Thanks @dcalhoun for adding this helpful test 🙇 .
(And sorry for the super late review 😅 )
Description
Fixes wordpress-mobile/gutenberg-mobile#3668. Relates to #32831. Adds tests asserting that block inserter inserts new blocks in the correct position after blurring the post title field.
How has this been tested?
Screenshots
n/a
Types of changes
Automated testing.
Checklist:
*.native.js
files for terms that need renaming or removal).