Iframe tablet and mobile device previews #33342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.44 kB (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
This was referenced Jul 10, 2021
ellatrix
force-pushed
the
try/iframe-device-preview
branch
from
be870a6 to
0394693
Compare
|
This is great, do you think there's a way to detect block failures and have a nice message like: "This block doesn't support rendering in frame, meaning it's not possible to render them in device previews". Would that even be desirable? |
|
I guess it's not easy to know if it's an iframe issue or not |
|
Right, it's hard to tell. I think in most cases, they block will render, but it could look strange (due to something not initialising for example). We'll have to see what kind of problems we get with the release of the template editor in 5.8. |
|
Should we move this to the 11.2 milestone? |
|
yeah ideally, we should leave milestone empty on PRs and let the auto-assign bot do its work post merge. |
ellatrix
force-pushed
the
try/iframe-device-preview
branch
from
0394693 to
8542560
Compare
ellatrix
force-pushed
the
try/iframe-device-preview
branch
from
8542560 to
d08d9cf
Compare
|
Let's merge this. This is necessary to push forward with the iframe and increase visibility to get more testing. I'll be on the lookout for any issues introduced. The device previews are not a super essential feature, so it's fine if a block has problems previewing so that we or plugin authors can identify the issues and fix them. |
|
I have an issue with the new iframe previews and my block. Is there any guide on how to make sure blocks work? My styles are broken in the iframe as well as the js initialization i guess. |
|
@ellatrix it seems all the |
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21193.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).