RNMobile: Fix slider and stepper text inputs in dark mode #33402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.04 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
guarani
added
the
Mobile App - i.e. Android or iOS
guarani
changed the title
2 tasks
ceyhun
reviewed
Jul 14, 2021
packages/components/src/mobile/bottom-sheet/range-text-input.native.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See wordpress-mobile/gutenberg-mobile#3724
This fixes a bug where sliders were not displaying properly in dark mode on iOS. Specifically, the text input field that's shown next to sliders (e.g. the Spacer block's height slider control) were showing dark text in dark mode.
This issue first appeared in https://github.com/WordPress/gutenberg/releases/tag/rnmobile/1.56.0 which was the first release after the RN 0.64 update (#29118).
It appears that RN used to use white as the default text input text color when dark mode was enabled, and we relied that for some time. In RN 0.64 however, this default behavior changed and now black is the default. This means we must now explicitly define text colors for text inputs and that's what this PR does.
Note: This also tweaks the Buttons block border radius test in #33211 to make it pass given the changes in this PR.
How has this been tested?
This fix is meant to address all
RangeTextInputcomponents. These are found in sliders:And steppers:
To test
Screenshots
The below screenshots how how the fix looks on sliders. The same applies for steppers.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).