[RNMobile] Disables supportsLayout by default on mobile #33847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
fluiddot
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
LGTM 🎊 !
Tested on iPad Pro (12.9-inch) (iOS 14.4) and Galaxy Samsung S20 FE 5G (Android 10).
Probably is out of the scope of this PR but I noticed that we don't have any test that covers the alignment functionality to prevent a case like this one in the future, what do you think about adding an integration or UI test?
|
Thank you for the prompt review @fluiddot and for detecting the issue and pointing to the solution 🙏
I agree with that and I think this is not out of scope for this PR. To avoid delaying the fix though I opened a separate issue to revisit this wordpress-mobile/gutenberg-mobile#3792 |
That's perfect, thanks for opening the issue 🙇 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles an incoming breakage after the merge of #33359 making the
Wide widthandFull widthalignment options unavailable. To achieve this thesupportsLayoutsetting introduced in #29335 is set by default tofalseon mobile.How has this been tested?
Wide widthandFull widthoptions are availableScreenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).