Components: Rename PolymorphicComponent* types to WordPressComponent*
#34330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
From what I can gather, until recently our preferred option in TypeScript files was to keep the type imports separate from importing runtime code. I believe this technique was used in an attempt to keep the bundle size as small as possible, e.g. import { myFunction } from './file';
import type { MyType } from './file';Recently, though, it was discussed and agreed that optimisation isn't really necessary, and so we started switching to merging those import statements into one, e.g. import { myFunction, MyType } from './file';Still, it is possible to still encounter an import type { MyType, MyOtherType } from './file';Following the rationale that I just explained, I had a look at the code in this PR and merged import declarations where possible in |
ciampo
force-pushed
the
feat/components-polymorphic-component-type-rename
branch
from
6508cd9 to
faa2953
Compare
|
All CI tasks seemed to be failing after the last commit — I've tried to rebase on top of Update: the issues seem to persist Update: all good after last rebase! Going to merge |
2 tasks
ciampo
force-pushed
the
feat/components-polymorphic-component-type-rename
branch
from
faa2953 to
c53dec6
Compare
ciampo
force-pushed
the
feat/components-polymorphic-component-type-rename
branch
from
c53dec6 to
9747a6a
Compare
This was referenced Sep 2, 2021
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the following types:
PolymorphicComponentWordPressComponentPolymorphicComponentPropsWordPressComponentPropsPolymorphicComponentFromPropsWordPressComponentFromPropsThis PR also renames the file containing the type definitions from
polymoprhic-component.tstowordpress-component.ts, and adds a CHANGELOG entry.How has this been tested?
The project builds correctly, tests pass, smoke tested in Storybook.
Screenshots
N/A
Types of changes
Refactor (type renaming)
Checklist:
*.native.jsfiles for terms that need renaming or removal).Closes #34291