Components: add reset timeout to ColorPicker's copy functionality. #34601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra and
chrisvanpatten
as code owners
ciampo
added
[Feature] Component System
ciampo
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
The code changes LGTM and the Storybook example works as expected — thank you for working on this!
I wonder if we should write a unit test for this piece of functionality — something like:
- focus on the color
- check if the DOM contains the string "Copy"
- click on the color
- check if the value has been copied on the clipboard and if the DOM contains the string "Copied"
- wait 3 seconds
- check if the DOM contains the string "Copy"
Finally, while testing, I released that keyboard support is not great around this "copy to clipboard" functionality, and opened #34795 to track this issue separately.
jorgefilipecosta
deleted the
add/reset-timeout-to-ColorPickers-copy-functionality-
branch
|
Thank you for the review @ciampo, I will follow up with the creation of a new unit test. |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 16, 2021
* trunk: (74 commits) Update docs for ClipboardButton component (#34711) Post Title Block: add typography formatting options (#31623) Bump plugin version to 11.5.0 Navigation Screen: Adjust header toolbar icon styles (#34833) Fix the parent menu item field in REST API responses (#34835) Rewrite FocusableIframe as hook API (#26753) Create Block: Remove wp-cli callout since not recommended and outdated (#34821) Global Styles: Fix dimensions panel default controls display (#34828) [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563) Increase Link UI search results to 10 on Nav Editor screen (#34808) Prevent welcome guide overflow x scroll (#34713) Enable open on click for Page List inside Navigation. (#34675) [RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update (#34674) Add missing field _invalid in menu item REST API (#34670) Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170) Navigation submenu block: replace global shortcut event handlers with local ones (#34812) Navigation Screen: Consolidate menu name and switcher (#34786) Remove parent and position validation from menu item REST API endpoint (#34672) Clean theme data when switching themes in the customizer (#34540) Components: add reset timeout to ColorPicker's copy functionality. (#34601) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34289
This PR fixes the issue #34289 by introducing a 3 seconds timer that resets the copied state allowing the user to copy the color again on the new color picker component after 3 seconds.
How has this been tested?
I verified that the UI of the "Copy" button resets (allowing the user to click the button again) after 3 seconds from the previous button click/press and that the "Copy!" button keeps copying the value to the clipboard as before.