-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child theme.json: update test to better capture that childs can update single parts in isolation #35759
Conversation
e4b8b00
to
d24b992
Compare
@oandregal, you might want to rebase on the latest |
I already did but it seems it's a different error in this case? cc @geriux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing for me locally 👍
Thanks for the ping, I restarted the job but it failed again, I'll investigate this. 👍 |
d24b992
to
724160e
Compare
Rebased again to see if that clears the new error out. |
ok, got a new one:
which I also see happening in |
Sorry for that, it looks like the propagation of the Github action changes are taking more than expected so we are hoping to fix it in this PR. |
724160e
to
da3f62d
Compare
Follow-up to #35459
Update so we test that single parts can be overridden by the child while untouched parent sections remain the same.