Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to communicate to screen readers that post title is textarea #35898

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Try to communicate to screen readers that post title is textarea #35898

merged 1 commit into from
Oct 26, 2021

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Oct 24, 2021 •
edited
Loading

Description

Tried to fix screen readers not seeing edit field for post title. Bug introduced in: #31569

Fixes #35440

How has this been tested?

Tested with JAWS and NVDA.

Screenshots

Types of changes

This is a Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@alexstine alexstine self-assigned this Oct 24, 2021
@alexstine alexstine added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Oct 24, 2021
@ellatrix ellatrix merged commit 77a2e0e into WordPress:trunk Oct 26, 2021
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 26, 2021
@andrewserong andrewserong added the [Type] Bug An existing feature does not function as intended label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@talldan talldan Awaiting requested review from talldan

Assignees

@alexstine alexstine

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.

accessibility: impossible to add or edit a post's title with Jaws for Windows screen reader activated
3 participants
@alexstine @ellatrix @andrewserong