Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Mobile responsive navigation by default. #35917

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Try: Mobile responsive navigation by default. #35917

merged 2 commits into from
Oct 25, 2021

Conversation

jasmussen
Copy link
Contributor

Description

Fixes #34511. Changes the navigation block to have mobile on by default:

Screenshot 2021-10-25 at 11 48 28

How has this been tested?

Insert a navigation block, start empty or add all pages, and verify the menu starts out responsive by default.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@jasmussen jasmussen added the [Block] Navigation Affects the Navigation Block label Oct 25, 2021
@jasmussen jasmussen requested a review from vcanales October 25, 2021 09:50
@jasmussen jasmussen self-assigned this Oct 25, 2021
@jasmussen jasmussen mentioned this pull request Oct 25, 2021
Closed
vcanales
vcanales approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty to regenerate fixtures so that checks will pass.

LGTM!

@jasmussen
Copy link
Contributor Author

Awesome! Thank you!

@jasmussen jasmussen merged commit a580ec6 into trunk Oct 25, 2021
@jasmussen jasmussen deleted the try/navigation-responsive branch October 25, 2021 12:34
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcanales vcanales vcanales approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@jasmussen jasmussen

Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.

Navigation Block: Consider having the responsive option on by default
2 participants
@jasmussen @vcanales