Scripts: Increase timeout for e2e tests #35983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] WP Scripts
gziolo
force-pushed
the
update/scripts-e2e-tests-timeout
branch
from
f869968 to
0ac3109
Compare
gziolo
commented
Oct 27, 2021
| @@ -9,17 +9,18 @@ const path = require( 'path' ); | |||
| const { hasBabelConfig } = require( '../utils' ); | |||
|
|
|||
| const jestE2EConfig = { | |||
| testRunner: 'jest-circus/runner', | |||
There was a problem hiding this comment.
I sorted config entries by name.
gziolo
force-pushed
the
update/scripts-e2e-tests-timeout
branch
from
0ac3109 to
54644fa
Compare
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
ryanwelcher
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Code looks good to me and I tested the 30 second value on WordPress/gutenberg-examples#174 and tests are running well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's increase the default timeout for e2e tests to 30 seconds.
+ testTimeout: 30000,@ryanwelcher tries to integrate e2e tests in WordPress/gutenberg-examples#174. It looks like the default value of 5 seconds doesn't play along well with CI. I don't have a strong opinion about the selected timeout value. I'm happy to update it to anything else that improves the experience.
Checklist:
*.native.jsfiles for terms that need renaming or removal).