FSE: Add template_type guards #36318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
requested review from
a team,
fullofcaffeine and
karmatosed
and removed request for
a team
5 tasks
youknowriad
approved these changes
Nov 9, 2021
ockham
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carried over from WordPress/wordpress-develop#1796; see https://github.com/WordPress/wordpress-develop/pull/1796/files#r744135286 for background.
props @hellofromtonya
Description
In two block template theme helper functions that attempt to access theme subdirectories based on
$template_type, add guards to make sure that it's eitherwp_templateorwp_template_part.How has this been tested?
Verify that block-based themes continue to work.
Types of changes
Minor improvement.