Navigation: Hide post attributes meta box #36358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
Mamaduka
added
[Block] Navigation
|
I was just trying to test this and couldn't replicate the issue on trunk (or on this branch). Tried TT1 Blocks, TwentyTwentyTwo on WordPress Version 5.8.1 and 5.9 alpha following the test instructions over at #36308. I created a new navigation menu in both the site and post editor, then edited the menu from
Could be just me! Am I missing something? Thanks! |
|
Thanks for testing, @ramonjd. Sorry, I forgot to mention that you'll need to create a custom template(s). It is when the second condition for this meta box goes into effect. |
Mamaduka
force-pushed
the
fix/nav-disable-post-attributes
branch
from
f358d62 to
c6b2ee3
Compare
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Thank you, @ramonjd. |
|
cc @andrewserong in case this needs to be cherry-picked in 11.9 since it's on the 5.9 must-have list. 🙇 |
andrewserong
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Navigation: Hide post attributes metabox * Update comment
|
Cherry picked into the Gutenberg 11.9 release in: cd3ce67 |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Navigation: Hide post attributes metabox * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables "Post Attributes" for wp_navigation post type.
The attributes are also conditionally enabled when a site has custom templates. Block Theme templates can be available for every post type.
You can find the condition here: https://github.com/WordPress/wordpress-develop/blob/f22abe76100ed3647392e5b58a926e7e081d7736/src/wp-admin/includes/meta-boxes.php#L1504-L1506
Fixes #36308
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).