-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix site editor reset styles in WP 5.9 #36390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
An existing feature does not function as intended
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Nov 11, 2021
Size Change: +93 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
fix/site-editor-reset-styles-in-5.9
branch
from
November 11, 2021 05:23
0ab3a98
to
e739c3e
Compare
noisysocks
force-pushed
the
fix/site-editor-reset-styles-in-5.9
branch
from
November 11, 2021 06:03
e739c3e
to
97949af
Compare
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Nov 11, 2021
noisysocks
added a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Core the site editor's body class is
.site-editor-php
, not.appearance_page_gutenberg-edit-site
. This causes the WP Admin footer to erroneously appear.How has this been tested?
wp-admin/site-editor.php
.Checklist:
*.native.js
files for terms that need renaming or removal).