Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about skip links to the block theme overview #36555

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

carolinan
Copy link
Contributor

Description

Adds short documentation for the skip link feature implemented with #30336.
Closes #34870.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Nov 17, 2021
@carolinan carolinan requested a review from ajitbohra as a code owner November 17, 2021 07:33
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

Thanks for your efforts to try to keep the documentation up to date!

@mkaz mkaz merged commit d9db09d into trunk Dec 9, 2021
@mkaz mkaz deleted the update/block-theme-overview-skip-link branch December 9, 2021 18:49
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 9, 2021
@jamieschmid
Copy link

jamieschmid commented Apr 24, 2024

Dev notes:
Because the nav is being loaded in the content and not in a separate template part, on most pages <main> is around the navigation as well, so it has no place to link to. This was a solution for us to have the floating main navigation.

Blog single posts: works, but I had to put <main> around the body copy only so it skips the post title
Blog categorie pages: works, but missing page title because same reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information about skip links to the block theme overview
3 participants