Disable Nav block editing for lower perm users #37029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
talldan,
spacedmonkey,
adamziel and
anton-vlasenko
getdave
added
[Block] Navigation
|
Size Change: +429 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
FYI If you do |
@getdave This call is incorrect. It should be |
Yeh I ended up figuring this one out via debugging the code. Thanks for clarifying though. |
getdave
force-pushed
the
try/disable-nav-block-for-lower-perm-users
branch
from
50a57b9 to
f1d7144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #36286 we learnt the Nav block provides a very poor UX for users with lower permissions.
The block should be readable but not writeable/editable.
This PR seeks to address that by:
Currently this uses a constant variable to indicate whether the user has suitable permissions. We will need to replace that with a call to
canUser()and ensure thewp_navigationpost type is configured with the correct perms.Addresses part of #36286
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).