Try to fix auto resizing in template part focus mode #37394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
requested review from
Mamaduka,
noisysocks,
talldan,
jameskoster,
paaljoachim and
ntsekouras
kevin940726
commented
Dec 15, 2021
| // Some themes will have `min-height: 100vh` for the root container, | ||
| // which isn't a requirement in auto resize mode. | ||
| <style> | ||
| { `.is-root-container { min-height: 0 !important; }` } |
There was a problem hiding this comment.
Not entirely sure if this makes sense in all cases though 🤔 .
|
Size Change: +1.69 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I'm still seeing the scrolling issue when the theme applies a border to the body: scroll.mp4Quadrat is working much better though :)
|
|
@jameskoster Just being curious, why would anyone wants to add border the the |
|
I used a border to add the blue/green gradient outline around the page in my theme:
Is it an anti-pattern? Maybe... but this was the only way I could think to achieve the desired effect and maintain predictable behaviour of the background color option in global styles. |
Interesting 🤔 ! I just pushed bc1a27b trying to fix this issue using a different approach (accessing |
|
Bingo :D
I tried a bunch of block themes for the directory and didn't see any issues except for one: Bai theme.
I couldn't see anything in the markup that would cause this, so maybe worth a check? |
|
@jameskoster Nice catch! I pushed some changes to address that as well. I also removed |
Mamaduka
approved these changes
Dec 28, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Try to fix auto resizing in template part focus mode * Force min-height: 0 in auto resize mode * Try fixing border issue and fix firefox bugs * Force min-height: 0 for body and html * Remove mutation observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #36141.
Try to fix auto resizing in Template Part focus mode with two changes:
height: fit-contentfor<body>and<html>.min-height: 0for the root containers.How has this been tested?
tt1-blocksorQuadrat.Screenshots
tt1-blocksQuadrat
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).