Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset inherited backgrounds on Posts Lists. #37941

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Unset inherited backgrounds on Posts Lists. #37941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/block-library/src/post-template/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
list-style: none;
padding: 0;

// Unset background colors that can be inherited from Global Styles with extra specificity.
&.wp-block-post-template {
background: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this approach we should also handle text and link color too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclude ul/ol which are blocks

If we could find some solid and low-specificity code that worked in the editor and frontend, I'd be fine with that too 👍 👍

But at the same time, I fundamentally don't think the inheritance is necessarily a big problem.

}

&.is-flex-container {
flex-direction: row;
display: flex;
Expand Down