Fix back button aria name in customizing widgets tests. #38195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
7 tasks
gziolo
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug discovered in #37078.
The back button also has a
:beforeelement with the content\f341which should be taken into account. In the previous version of puppeteer, it was not included when accessingcomputedName. A simple solution is to use regexp rather than string literal to match the name.How has this been tested?
E2E tests should pass
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).