Scripts: Improve the handling for build entry points #38584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
ryanwelcher
approved these changes
Feb 7, 2022
gziolo
added
the
Developer Experience
|
This prevents passing custom entry point in our workflow. Exemple: import config from "../../config.js"
/** Gulp and utils **/
import gulp from 'gulp'
const {src, dest} = gulp
import named from 'vinyl-named'
/** Webpack **/
import webpack from 'webpack-stream'
import webpackConfig from "@wordpress/scripts/config/webpack.config.js"
webpackConfig.entry = null
/**
* Scripts
*/
export const process_js = () => src( config.paths.scripts_sources.src )
.pipe( named() )
.pipe( webpack( webpackConfig ) )
.pipe( dest( config.paths.scripts_sources.dst ) )Returns the error: Please revert: if ( ! entryFile ) {
log(
chalk.bold.red( 'No entry files discovered in the "src" folder.' )
);
exit( 1 );
}
to if ( ! entryFile ) {
return {};
} |
|
@loxK, I see what happened. https://webpack.js.org/concepts/entry-points/#object-syntax Thank you for the report. I will work on the fix today and publish hotfix to npm 👍🏻 |
|
@gziolo awesome thank you |
4 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38526.
As reported by @markcummins:
I resolved the issue by removing the path to the
srcdirectory in the project instead of splitting the path by the location ofsrc/.In addition to that, I added warnings and errors with detailed description what can be improved in the configuration.
Testing Instructions
Run:
Try removing a script referenced in the
block.jsonand run the build again:You should see an error message.
Try adding in
block.jsona path to a script that is outside ofsrcfolder and watch for warning when running the build again.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).