[ New block ] - Create a Generic Avatar block for Authors #38591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
requested review from
ajitbohra,
mkaz,
ryanwelcher,
spacedmonkey and
TimothyBJacobs
as code owners
cbravobernal
removed request for
mkaz,
spacedmonkey,
ajitbohra,
ryanwelcher and
TimothyBJacobs
|
Size Change: +1.4 kB (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
cbravobernal
commented
Feb 8, 2022
gziolo
reviewed
Feb 9, 2022
13 tasks
cbravobernal
force-pushed
the
try/unify-user-avatar
branch
5 times, most recently
from
456f650 to
186f3de
Compare
cbravobernal
changed the title
cbravobernal
force-pushed
the
try/unify-user-avatar
branch
from
78d7be2 to
2905ac2
Compare
carolinan
reviewed
Feb 17, 2022
| value={ attributes?.size } | ||
| /> | ||
| <ToggleControl | ||
| label={ __( 'Link to user profile' ) } |
There was a problem hiding this comment.
I think that this text may be incorrect for the comments, where the link is often an external website?
There was a problem hiding this comment.
I thought about it. But also, I changed the website on the user settings and could not see any website link.
Do we know from where WordPress fetch that information?
Could we rephrase to 'Link to user website or author archive'?
cbravobernal
added
Needs Design Feedback
cbravobernal
force-pushed
the
try/unify-user-avatar
branch
from
2905ac2 to
1cc7977
Compare
|
This seems useful enough 👍 👍 |
cbravobernal
force-pushed
the
try/unify-user-avatar
branch
from
ba612c9 to
693c74e
Compare
ockham
reviewed
Mar 22, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
…38591) Co-authored-by: Michal Czaplinski <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: José Arcos <[email protected]> Co-authored-by: Bernie Reiter <[email protected]>
|
Thank you for completing this. |
This was referenced Mar 25, 2022
|
Hello @c4rl0sbr4v0 thanks for your great job, on my side it seems like it doesn't work as well. Here is the test report: -Wordpress 5.9.2
Please tell me if I am doing something wrong. |
Hi!
Avatar plugins in this case, if they want to be ready for the site editor, will need to update the REST API user endpoint to show their data I guess. |
|
I am thinking the best option would actually give the opportunity to the user to choose an image through the sidebar settings as an avatar. Instead of needing to use Gravatar as there are a lot of users who do not use the Gravatar service (which for some countries I believe is a breach of GDPR). I posted a link to my comment in the core-privacy slack channel. To get some additional feedback. |
Do you mean in the sidebar of the block editor? Then I disagree, that would be a horrible disconnect from the general WordPress avatar feature (which mostly relies on the |
|
I am not seeing the full picture here. Really my only focus here in regards to this PR was on making it easier for a user to add in an avatar image and if they do not have a Gravatar that they should be able to choose an image from the Media Library. The broader picture is being able to select an image not connected with the Gravatar service in the user profile screen. Here is a very long trac ticket: https://core.trac.wordpress.org/ticket/16020 |
So what would the effect of picking an "avatar" just for that block be? You'd have an image there that is not what
Yes, I know that ticket. It is unfortunate that Matt's intervention again stalled the momentum it had gathered. |
|
Hey @mundschenk-at Please no blaming here. There are just additional concerns that are needed to be looked at. I am hoping to spark some discussions again in relation to using a local avatar again through the core-media and core-privacy channels on Slack. We will see how it goes. Thanks for chiming in. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A Proof of Concept of having a generic Avatar block for anywhere we could use it on a WordPress Site.
It would deprecate
Comment Author Avatar, and also it would avoid the creation of one specific block forPost Author Avatar(#38265 can be closed if we merge this one)Partial for #35596
Also closes #31962, #35693, #38456
Why
Using this approach we increase the logic of the code, but also, simplify the user experience. The user may not know the differences between a post or a comment author avatar. Just want an avatar to be displayed in some part of the site.
Also, with this case, we add the possibility of adding avatars outside of the post-comment context. For example, creating a "review product pattern", a "list of authors pattern", etc.
How
In this PR we create a new Core block that:
duotone,border,alignment,spacingandcoloroptions.Screenshots
Video demo
Video Demo
How to test
Create some users with avatars. A couple of posts. And then: