TreeGrid: Add Home/End keys to jump to start/end of grid #38679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
added
[Type] Enhancement
|
@MarcoZehe I always thought it would be better UX if the Home/End key jumped to the beginning/end item of an expanded |
|
Size Change: +26 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
MarcoZehe
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Yeah, for non-tree grids I would agree that home and end should move to the beginning/first or end/last data column of a row, but for tree grids, the behavior you implemented here is actually appropriate and will allow for quick navigation. AKA the first objective in a tree grid is to get to a particular row, and only then interact with its columns. So LGTM.
|
Looks good to me too. Thanks for another great improvement 🎉 |
|
Hey folks, I noticed a few great accessibility fixes / improvements on It would be great if we could also add a few unit tests to make sure we don't introduce any regressions around these areas in the future— would that be possible? |
|
@ciampo Is there a needs-tests label or something? Problem is, I am not a sponsored contributor so what I have time for is what I have time for. I would like to get more involved with writing and extending tests but between working out code structure and fixing accessibility bugs, that's about all the time I have ATM. Is there anyone who likes writing tests floating around the community right now? Thanks. |
|
Hey @alexstine , I get your point and I continue to really appreciate your contributions! The reason why I'm pointing out the lack of tests, is that without a test, all of the work that you put in has the change to be reverted in the future. Unit tests would help us avoid any potential regressions, and in my personal opinion in this scenario can be as important as the fix itself. I'd personally almost prefer to have, given the same span of time, one PR with a bug fix a corresponding unit tests, than two PRs with two bug fixes and no unit tests associated.
I don't think that there's anyone around who specifically writes unit tests. @mirka and I try our best to support folks working on For now I've opened #38735 to track this task.
There is one similar label, but it seems to be used for issues that need to be triaged. |
|
@ciampo Thanks for the tracking issue. I'll try to work on it but no promises right now. |
|
Similarly, there should really be more e2e tests for the List View feature. 😅 I've created an issue for that - #38774. |
|
Thank you @alexstine and @talldan for your replies and your continued effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the ARIA spec, Home/End keys must jump to the beginning/end of the TreeGrid.
https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-2/treeview-2a.html
Testing Instructions
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).