Data: enable thunks by default and remove the experimental flag #38853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
requested review from
draganescu,
talldan,
tellthemachines,
adamziel,
kevin940726,
getdave,
noisysocks,
ellatrix,
nerrad,
ajitbohra,
mkaz and
ryanwelcher
as code owners
|
Size Change: -187 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
8 tasks
|
Fantastic! Great work, @jsnajdr leading all the efforts 👏 Could there be any issues with 3rd party stores used by plugins now that this is always enabled? I assume no, but it’s always conforming to see confirmation 😃 |
@gziolo theoretically there could a conflict with custom middlewares, especially ones handling thunks. If we want to maintain 100% backwards compatibility then thunks would have to remain opt-in. I wonder how much of a problem that actually is, though cc @jsnajdr |
I think such a conflict can't happen. First, |
|
At any rate we're bumping the |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thunks API has been around for quite a long time (one year, since #27276) and all Gutenberg stores have been migrated to it. That means that the API is battle tested and stable, and we can graduate it from the experimental status to stable. This PR does that. Removes the
__experimentalUseThunksflag for store config and enables the thunk middleware by default for all stores.