Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Removing comma so that the code snippet of theme.json represents standard JSON. #38938

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Feb 21, 2022

Description

When I'm loafing and weary I copy and paste a lot.

I was using the theme.json snippet over at https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-json/#presets and noticed there was a trailing comma in the JSON.

This PR removes it.

This change will save you a second of your time, but maybe minutes of developer time throughout the world!

Screenshots

Screen Shot 2022-02-21 at 1 18 04 pm

Types of changes

Documentation quality.

@ramonjd ramonjd added the [Type] Developer Documentation Documentation for developers label Feb 21, 2022
@ramonjd ramonjd self-assigned this Feb 21, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply beautiful - surely a strong contender for PR of the week 😄

@ramonjd ramonjd merged commit b44f513 into trunk Feb 21, 2022
@ramonjd ramonjd deleted the update/theme-json-doc-code-snippet branch February 21, 2022 03:05
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 21, 2022
@cbravobernal cbravobernal changed the title Documentation: Removing comma so that the code snippet represents standard JSON Documentation: Removing comma so that the code snippet of theme.json represents standard JSON. Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants