Migrate/e2e to playwright round one #38949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Max Schmitt <[email protected]>
|
Size Change: +46 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
@kevin940726 I'm encountering an issue, and I'm not really sure about what is causing it. I have the style-variation.spec.js test, which uses some utilities in inserter.js. When I run the tests, I get this error
The utilities are properly exported in index.ts though. Is there something I'm missing? |
kevin940726
reviewed
Feb 24, 2022
| * @param {string} searchTerm The text to search the inserter for. | ||
| */ | ||
| export async function insertBlock( searchTerm ) { | ||
| await searchForBlock( searchTerm ); |
There was a problem hiding this comment.
We can't just call the util because it depends on this to bind to PageUtils. Since we're operating under strict mode (the default), calling a function directly inside another function will set this to undefined. Instead, expose the util in PageUtils and call this.searchForBlock.
Suggested change
| await searchForBlock( searchTerm ); | |
| await this.searchForBlock( searchTerm ); |
I agree it could be quite annoying to have to handle this though, open to any other ideas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #38570.
This PR adds some e2e tests with Playwright.
See #38851 for overview of the migration progress.