Dom: Avoid RangeError in findPrevious method #38961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] DOM
|
Size Change: +84 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
talldan
reviewed
Feb 22, 2022
talldan
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed this error while running e2e tests.
The
findPrevioususes return value fromArray.indexOfto set length focusables, which can be-1when the element isn't in an array and causeRangeError: Invalid array lengtherror.Testing Instructions
It is a little hard to reproduce this error manually. However, you can run the following e2e test and confirm it doesn't throw an error:
The error happens during the "allows tabbing in navigation mode if no block is selected (reverse)" test.
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).