Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated popovers.test.js to Playwright #39910

Merged
merged 9 commits into from
May 8, 2022
Merged

Migrated popovers.test.js to Playwright #39910

merged 9 commits into from
May 8, 2022

Conversation

shanjidah
Copy link
Contributor

What?

Based on #38570, part of #38851. Popovers popovers.test.js to its Playwright counterpart.

Why?

Migration to Playwright

How?

Migration to Playwright

Testing Instructions

npm run test-e2e:playwright -- test/e2e/specs/editor/various/popovers.spec.js

Screenshots

Screenshot 2022-03-30 at 11 49 45 PM

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shanjidah! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 30, 2022
@shanjidah shanjidah changed the title Add playwright test case popovers.spec.js Migrated popovers.test.js to Playwright Mar 30, 2022
@shanjidah
Copy link
Contributor Author

@kevin940726 Can you please add it in #38851?

@kevin940726 kevin940726 mentioned this pull request Mar 31, 2022
Closed
kevin940726
kevin940726 reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the PR!

There are some potential improvements we can make to make it follow the best practices though. Also the Playwright documentation is a good resource to start with when first writing tests.

Feel free to ask any questions you may have :), either here or in the #core-test Slack channel.

test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
@skorasaurus skorasaurus added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 9, 2022
@shanjidah
Copy link
Contributor Author

Hey @kevin940726 👋
Thanks for reviewing this PR. I have already solved all the commented issues. Hope now it's all good. Could you please review it once again & let me know if I am missing anything.

@shanjidah shanjidah requested a review from kevin940726 April 23, 2022 10:30
kevin940726
kevin940726 reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Just some minor feedback/nitpickings left 💯

We should also remove the original test file though :).

test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
@shanjidah shanjidah requested a review from kevin940726 May 2, 2022 06:06
kevin940726
kevin940726 reviewed May 3, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some small copy-paste errors left!

Note that we should also remove the original test file (packages/e2e-tests/specs/editor/various/popovers.test.js) too :)

test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/popovers.spec.js Outdated Show resolved Hide resolved
@shanjidah shanjidah requested a review from kevin940726 May 7, 2022 14:31
kevin940726
kevin940726 approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯! Thanks a lot! ❤️

@kevin940726 kevin940726 merged commit d5d8954 into WordPress:trunk May 8, 2022
@github-actions github-actions bot added this to the Gutenberg 13.3 milestone May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@shanjidah @kevin940726 @skorasaurus