-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Space to indent list item #39949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +79 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/space-to-indent-list-item
branch
from
March 31, 2022 15:07
2944de2
to
3c01ea8
Compare
ntsekouras
force-pushed
the
add/space-to-indent-list-item
branch
from
May 10, 2022 10:51
3c01ea8
to
341f076
Compare
ntsekouras
reviewed
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorgefilipecosta! Besides my small comment about the shortcut
, this works as expected 💯
jorgefilipecosta
force-pushed
the
add/space-to-indent-list-item
branch
from
May 10, 2022 14:20
341f076
to
94949b9
Compare
Thank you for the review @ntsekouras I applied/answered to your feedback. |
ntsekouras
approved these changes
May 10, 2022
jorgefilipecosta
force-pushed
the
add/space-to-indent-list-item
branch
from
May 10, 2022 16:29
94949b9
to
4145135
Compare
ntsekouras
force-pushed
the
add/space-to-indent-list-item
branch
from
May 11, 2022 09:13
4145135
to
c9dc250
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to indent a list item when space is pressed in be beginning of a list item.
Fixes: #39875
Testing Instructions
I verified that by pressing space in the begging of a list item I can indent it.