Nav link block PHP tests replace prefixed function with non-prefixed

[getdave]

What?

Replaces the usage of prefixed gutenberg_render_block_core_navigation_link with non-prefixed render_block_core_navigation_link in the PHP Unit tests.

Here's an example where they are failing:

https://github.com/WordPress/gutenberg/runs/6195031409?check_suite_focus=true

Why?

It looks like the Nav Link block PHP Unit tests have been relying on the gutenberg_ prefixed version of the block's render function.

gutenberg/phpunit/class-block-library-navigation-link-test.php

Line 105 in b8aa52d

gutenberg_render_block_core_navigation_link(

However, this function does not exist in Gutenberg Core so I assume it existed in WP Core. It looks like it was recently removed and thus causes a bug in the PHP unit tests.

How?

Just renaming.

Testing Instructions

Run PHP unit tests for phpunit/class-block-library-navigation-link-test.php. Check no failures.

Screenshots or screencast

Example of failing tests

[adamziel]

• In the plugin, this function has been called render_block_core_navigation_link for a while.
• I noticed it's renamed to gutenberg_render_block_core_navigation_link during the plugin build process.
• In my local test environment, both render_block_core_navigation_link and gutenberg_render_block_core_navigation_link exists and I'm unable to reproduce the error.

Super weird! cc @youknowriad @gziolo

[gziolo]

In my local test environment, both render_block_core_navigation_link and gutenberg_render_block_core_navigation_link exists and I'm unable to reproduce the error.

It's only the case when you run npm run build because webpack will copy the file to build and rename the function 😄

That's the risk of doing too much magic in the build process.

[adamziel]

I cherry picked this change into wp/6.0 branch to be included in WordPress 6.0 RC1: 12a4722