Gallery block: make full image clickable when link and caption applied #40713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k works across full image
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +35 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Changes make sense to me 👍
I'm not sure about the accessibility concern though (should text always be selectable?), but I guess that's acceptable if we have aria-label or similar assistive label.
I also noticed there's a e2e test error on the gallery test, seems unrelated but might worth to check it out?
|
Image captions have a link option, this renders the link unusable with a mouse or other pointer. |
Doh! Good points - thanks for catching both of these @carolinan. Will take another look, but hard to see any option for making both the image link and the caption links clickable. |
|
Is it just me? I can no longer edit the captions at all...
|
Gotcha number 3, which is obviously why nobody tried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure full gallery image is clickable when a link is applied and also a caption
Why?
Fixes: #14304 Currently if a gallery image has a caption the portion of the image with the caption is not clickable to follow the attached link
How?
Applies
pointer-events: noneto caption to allow click events to fall through to image anchorTesting Instructions
Screenshots or screencast
Before:
gallery-links-before.mp4
After:
gallery-link-after.mp4