Add eslint warning about use of waitForTimeout to playwright eslint #40802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Automated Testing
|
Size Change: +90 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 4, 2022
Ah, true - the dangers of copy and paste - updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an eslint warning about the use of waitForTimeout to playwright eslint config
Why?
Puppeteer has a warning added to prevent people use waitForTimeout and to prompt to use waitForSelector instead as this is best practice.
How?
Copied the relevant config from the puppeteer config to the playwright config
Testing Instructions
Try adding
await page.waitForTimeout(1000);to a playwright test, eg.test/e2e/specs/editor/plugins/image-size.spec.jsand check that you get an eslint warning