Post Terms: Add wp_kses_post to prefix/suffix for consistency #40803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
ntsekouras
approved these changes
May 6, 2022
There was a problem hiding this comment.
Thanks for the PR @andrewserong!
This doesn't hurt of course, but since we are not disabling the formats in the RichText instances used in edit function, the formats are preserved and other html is treated as string. I'm approving and leave this to you 😄
aristath
approved these changes
May 6, 2022
|
Size Change: +56 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Thanks for the reviews, and the feedback @ntsekouras! I've added in While I was editing that file, I also added in I'll merge this in once tests pass. |
…create a paragraph block when hitting enter at the end of the Suffix field
andrewserong
force-pushed
the
update/post-terms-prefix-suffix-kses
branch
from
11a979e to
1e99fb6
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following on from #40776 and #40559, this adds
wp_kses_postto the Post Terms prefix and suffix fields.Also:
allowedFormatsto reduce the allowed formats for consistency with other blocks like Navigation Link (we probably only really need bold, italic, image, strikethrough rather than keyboard / super/subscript options) – I also added in link and text color, as they're probably still useful here.__unstableOnSplitAtEndto the suffix field so that if someone presses enter at the end of the suffix, it adds a Paragraph block instead of a newline character to the suffix field.Why?
This probably isn't really necessary, but for consistency with the other blocks that have RichText fields and server-render those fields, I thought we could add it in. (Happy to close this out if folks think it doesn't need it).
How?
Wrap the prefix and suffix in
wp_kses_postTesting Instructions
On a post with tags attached, add a Post Tags block, and enter text in the prefix or suffix fields. Using the RichText controls, set some of the text to bold or italic and ensure it still renders correctly on the frontend.
Screenshots or screencast