Migrate 'block-locking' to Playwright #41050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
Mamaduka
requested review from
ntsekouras
and removed request for
ntwb,
ajitbohra and
nerrad
|
Thanks for the review, Nik 🙇 |
kevin940726
reviewed
May 19, 2022
|
|
||
| await editor.clickBlockOptionsMenuItem( 'Lock' ); | ||
|
|
||
| await page.click( 'role=checkbox[name="Prevent removal"]' ); |
There was a problem hiding this comment.
Nit: Ideally, we normally want to add the i flag to indicate case insensitive names:
-await page.click( 'role=checkbox[name="Prevent removal"]' );
+await page.click( 'role=checkbox[name="Prevent removal"i]' );There was a problem hiding this comment.
I was wondering about the flag since I saw it in other tests. Most labels can be considered case insensitive, should we include this into migration or best practices docs?
I also ended up using .toBe() instead of .toMatchInlineSnapshot(). Is this also recommended way to test small pieces of content?
There was a problem hiding this comment.
Most labels can be considered case insensitive, should we include this into migration or best practices docs?
That would be nice! However, we're still using the unofficial role-selector created by me. After we switch to the official role selector when it becomes stable, we can just omit the " to make it more ergonomic.
-await page.click( 'role=checkbox[name="Prevent removal"i]' );
+await page.click( 'role=checkbox[name=Prevent removal]' );We can do this in one go though.
I also ended up using
.toBe()instead of.toMatchInlineSnapshot(). Is this also recommended way to test small pieces of content?
Yes, I don't think it's currently possible to use toMatchInlineSnapshot() in playwright test runner. So we either have to use .toMatchSnapshot() or just .toBe().
There was a problem hiding this comment.
After we switch to the official role selector when it becomes stable, we can just omit the " to make it more ergonomic.
I thought it became stable in v1.22.0.
There was a problem hiding this comment.
Oh awesome! Didn't catch that. I think we can migrate it to the official selector then :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Port of #38851.
Migrate Block Lockings e2e tests to Playwright
Why?
These are relatively new e2e tests, and I should've used Playwright from the beginning. I'm also planning to add more test cases, so I decided to migrate early.
How?
I followed migration steps - https://github.com/WordPress/gutenberg/blob/trunk/test/e2e/MIGRATION.md.
Testing Instructions