Navigation block: Only focus submenu trigger on escape key press #41986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
added
[Type] Bug
|
Size Change: +2.44 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Jun 28, 2022
There was a problem hiding this comment.
Code looks good 👏🏻 Let's have a second round of testing from @afercia 🙏🏻
|
@draganescu hello. Quick question, when you have a chance: is the submenu navigation |
|
@afercia |
afercia
reviewed
Jul 6, 2022
| @@ -63,11 +61,13 @@ window.addEventListener( 'load', () => { | |||
| '.wp-block-navigation-item.has-child' | |||
| ); | |||
There was a problem hiding this comment.
I see some room for performance improvements here, as this run for any keyup event on the page for example for any Tab key press or even when typing within an input field or textarea. It's part of the existing implementation though so I'll open a separate issue.
afercia
reviewed
Jul 6, 2022
| closeSubmenus( block ); | ||
| // Focus the submenu trigger so focus does not get trapped in the closed submenu. | ||
| toggle.focus(); |
There was a problem hiding this comment.
When testing with a menu with nested submenu, this triggers an error:
Uncaught TypeError: Cannot read properties of null (reading 'focus')
That's because:
- the script loops through all the submenu blocks
- for each submenu block, it gets the toggle with an aria-expanded="true" attribute
- then it closes all the submenu and switches aria-expanded to false
- at this point, it loops to the second submenu block, where the toggle has now an aria-expanded set to false
- querySelector returns null and
toggleis null - attempting to set focus on
nulltriggers the error
I think it would be sufficient to check for the toggle existence before attempting to set focus on it or alternatively return it it's null before setting focus.
Of course, this should be fixed also in the other file for the submenu.
There was a problem hiding this comment.
@afercia Better now?
@draganescu thanks. I do see |
|
LGTM 👍 Restarted one e2e job that faield, waiting to see if it passes. |
afercia
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41975
Why?
My last change introduced too much bad UX behavior.
How?
Only target escape key press to place focus on the submenu trigger.
Testing Instructions
Screenshots or screencast