Document Settings: Make Post Format, Slug and Author fields fill the sidebar #42146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
noisysocks
commented
Jul 5, 2022
Comment on lines
-1
to
-10
| .editor-post-author__select { | ||
| margin: -5px 0; | ||
|
|
||
| // Set the width of the author select box in IE11 to prevent it overflowing | ||
| // outside of the container because of IE11 flexbox bugs. | ||
| // We reset it to `width: auto;` for non-IE11 browsers. | ||
| width: 100%; | ||
| @supports (position: sticky) { | ||
| width: auto; | ||
| } |
There was a problem hiding this comment.
This appears to be dead code.
|
Size Change: -121 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
It looks good to me! |
Mamaduka
reviewed
Jul 5, 2022
Mamaduka
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
This tests well for me, @noisysocks 👍
Question: Do you think removing some classes makes it a backward-compatibility breakage?
Mamaduka
reviewed
Jul 5, 2022
| @@ -41,25 +42,19 @@ export class PostSlug extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { instanceId } = this.props; | |||
| const { editedSlug } = this.state; | |||
There was a problem hiding this comment.
The slug change from URL form isn't reflected in the slug text field without page refresh.
There was a problem hiding this comment.
Looks like this bug exists on trunk too so I'm just going to plow ahead.
For context I think this component was added back when we used the post editor for templates and template parts but was never removed and now we're stuck maintaining it. In theory a plugin can add add_post_type_support( 'post', 'slug' ) but I do not see any evidence that this is happening.
We don't officially consider class names as part of the public API, so no, but my view is that it's best to minimise class name changes. In this PR the removed class names are for elements that are being removed so we can't offer an alternative. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tidies up the Post Format, Slug and Author fields by making them fill the width of the document settings sidebar.
Why?
Related to #39082. I noticed these fields looked pretty janky and so spoke with @javierarce about how we can clean them up with minimal effort.
How?
Tweaked the CSS and switched these controls over to using
SelectControlandTextControl.Testing Instructions
gutenberg.phpso that you see Slug:add_post_type_support( 'post', 'slug' ).