Migrate register block test case to playwright #43170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevin940726, Hope you are doing well! Can you please help in reviewing this PR? |
talldan
added
the
[Type] Automated Testing
talldan
reviewed
Aug 25, 2022
|
|
||
| expect( | ||
| page.locator( | ||
| '.block-editor-block-types-list[aria-label="Widgets"] > .editor-block-list-item-paragraph' |
There was a problem hiding this comment.
Thank you for working on another migration 😄
It should be ok to use a role selector for this, I think it would be something like this, but I haven't tested to make sure it works:
Suggested change
| '.block-editor-block-types-list[aria-label="Widgets"] > .editor-block-list-item-paragraph' | |
| 'role=listbox[name="Widgets"i] >> role=option[name="Paragraph"i]' |
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate register-block-type-hooks.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright test/e2e/specs/editor/plugins/register-block-type-hooks.spec.js