Storybook: Add margin checker tool #43223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 16, 2022
Comment on lines
+15
to
+21
| background-image: repeating-linear-gradient( | ||
| 45deg, | ||
| transparent, | ||
| transparent 2px, | ||
| #e0e0e0 2px, | ||
| #e0e0e0 14px | ||
| ); |
There was a problem hiding this comment.
This use of gradient is so much fun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a margin checker tool in the Storybook to easily check whether the component has unwanted top/bottom margins.
Why?
I don't want to clutter up the toolbar with too many things, but deprecating margins (#39358 #38730) is one of the on-going things we'll be working on. Margins aren't easy to detect without some visible elements sandwiching the component in question.
How?
Add a simple Storybook decorator that injects bumper divs before and after the story.
Testing Instructions
npm run storybook:devScreenshots or screencast
CleanShot.2022-08-15.at.18.55.22.mp4