(Custom)GradientPicker: Add flag to remove margins #43387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Package] Components
|
Size Change: -12 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mirka
commented
Aug 18, 2022
Comment on lines
-21
to
-23
| .components-custom-gradient-picker__gradient-bar { | ||
| margin: $grid-unit-20 0 $grid-unit-15; | ||
| } |
There was a problem hiding this comment.
This override in the block editor, which is the only place where DuotonePicker is used, tells us that these are the actual intended margins. These values are now moved into the DuotonePicker itself.
| Before | After |
|---|---|
 |
 |
Comment on lines
-9
to
-12
| margin-top: $grid-unit-15; | ||
| width: 100%; | ||
| height: $grid-unit-60; | ||
| margin-bottom: $grid-unit-20+$grid-unit-05; |
There was a problem hiding this comment.
Since CustomGradientBar is an internal-only component, we fully remove these margins, and let the publicly exported consumer components handle the back compat concerns.
| .components-custom-gradient-picker { | ||
| &:not(.is-next-has-no-margin) { | ||
| margin-top: $grid-unit-15; | ||
| margin-bottom: $grid-unit-30; |
There was a problem hiding this comment.
$grid-unit-30 here is the $grid-unit-20 from components-custom-gradient-picker__ui-line plus the $grid-unit-10 from the bottom margin on AnglePickerControl.
There was a problem hiding this comment.
It looks like AnglePickerControl has the __nextHasNoMarginBottom prop always set to true, how does it contribute to the margin bottom ?
Kapture.2022-08-18.at.20.10.41.mp4
There was a problem hiding this comment.
We could've said margin-bottom: $grid-unit-20 on L6 and passed __nextHasNoMarginBottom={ __nextHasNoMarginBottom } to AnglePickerControl, and it would have the same effect. I just merged those two things into a single margin-bottom: $grid-unit-30 back compat at the top-level.
20 tasks
|
cc @ntsekouras — since we were talking about this earlier today! Here's an example of the effort that we're going through in the components package to remove outer margins from components |
ciampo
approved these changes
Aug 18, 2022
| .components-custom-gradient-picker { | ||
| &:not(.is-next-has-no-margin) { | ||
| margin-top: $grid-unit-15; | ||
| margin-bottom: $grid-unit-30; |
There was a problem hiding this comment.
It looks like AnglePickerControl has the __nextHasNoMarginBottom prop always set to true, how does it contribute to the margin bottom ?
Kapture.2022-08-18.at.20.10.41.mp4
Comment on lines
-9
to
-12
| margin-top: $grid-unit-15; | ||
| width: 100%; | ||
| height: $grid-unit-60; | ||
| margin-bottom: $grid-unit-20+$grid-unit-05; |
| @@ -117,6 +120,11 @@ export default function GradientPicker( { | |||
| ? MultipleOrigin | |||
| : SingleOrigin; | |||
|
|
|||
| // Can be removed when deprecation period is over | |||
mirka
force-pushed
the
gradient-picker-margins
branch
from
b970633 to
40f8746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358 #43014
What?
__nextHasNoMarginflag on CustomGradientPicker/GradientPicker to remove top and bottom margins.components-custom-gradient-picker__gradient-bar, which indicates that it was never ready to be a standalone component.)Why?
For better reusability.
How?
Testing Instructions
npm run storybook:devScreenshots or screencast
CleanShot.2022-08-18.at.19.23.47.mp4