Comments block (legacy mode): Update warning message wording #43527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Block] Comments
ockham
commented
Aug 23, 2022
| 'For better compatibility with the Block Editor, ' + | ||
| 'please consider switching the block to its editable mode.' | ||
| "Comments block: You're currently using the legacy version. " + | ||
| 'The following is just a placeholder -- it might look different on the frontend. ' + |
There was a problem hiding this comment.
Is it okay to refer to the "frontend" here? Is that a term our users are familiar enough with? Do we use it elsewhere?
There was a problem hiding this comment.
I think I'd try to avoid it. IMO, the previous phrase "final styling" was more accessible to non-technical users.
ockham
commented
Aug 23, 2022
| 'please consider switching the block to its editable mode.' | ||
| "Comments block: You're currently using the legacy version. " + | ||
| 'The following is just a placeholder -- it might look different on the frontend. ' + | ||
| 'For a better representation and more customization options, ' + |
There was a problem hiding this comment.
Two benefits:
- It's a more faithful visual representation of the outcome on the frontend.
- It can be edited: not just customizing fonts etc, but also re-arranging Comments Title/Author/Content blocks, adding other blocks, etc. Not sure how to best call that, so I went with "customization" for all of them. Any better ideas? How about
Suggested change
| 'For a better representation and more customization options, ' + | |
| 'For a better representation and more composition and customization options, ' + |
|
Size Change: +3.16 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Co-authored-by: Michal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the wording of the Comments block's legacy mode warning message.
Why?
The previous message was too long and verbose.
How?
The new message is based on @annezazu's suggestion from here:
I've modified that suggestion a bit:
I'm open to changing the copy some more -- I realize it might not be quite there yet 😅
Testing Instructions
You need the legacy mode of the Comments block. This is easily accessed by e.g. editing the "Single" template of the TT2 theme, or by manually inserting
<!-- wp:comments {"legacy":true} /--></div>into the Code Editor.Screenshots or screencast