Lodash: Remove from blocks API raw handling #43575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Feature] Paste
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
noisysocks,
gziolo,
swissspidy,
ellatrix,
kevin940726,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
sgomes
approved these changes
Aug 24, 2022
| @@ -39,7 +38,13 @@ function isFigureContent( node, schema ) { | |||
| function canHaveAnchor( node, schema ) { | |||
| const tag = node.nodeName.toLowerCase(); | |||
|
|
|||
| return has( schema, [ 'figure', 'children', 'a', 'children', tag ] ); | |||
| return ( | |||
There was a problem hiding this comment.
This is a bit unwieldy. How about:
return tag in ( schema?.figure?.children?.a?.children ?? {} )?
There was a problem hiding this comment.
Clever suggestion - thanks 👍 I like it. Going to use it for both the has() instances.
|
Size Change: +89 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash usage from the block the API for raw handling.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing all Lodash usage with native functionality.
Testing Instructions
npm run test:unit packages/blocksnpm run test:unit test/integration