Fix duplicate navigation block props #43596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Aug 25, 2022
| } ); | ||
| const innerBlocksProps = useInnerBlocksProps( | ||
| { | ||
| className: 'wp-block-navigation__container', |
There was a problem hiding this comment.
Matches innerBlocksProps elsewhere.
talldan
commented
Aug 25, 2022
| @@ -172,18 +171,9 @@ export default function UnsavedInnerBlocks( { | |||
| const Wrapper = isSaving ? Disabled : 'div'; | |||
|
|
|||
| return ( | |||
| <Wrapper className="wp-block-navigation__unsaved-changes"> | |||
There was a problem hiding this comment.
There used to be an overlay to prevent direct manipulation, but I don't think this is needed anymore. It causes the styling of the inner blocks to be incorrect. There must be direct descendent selectors among the block styles, so I think it's best to try to match the DOM structure that the block normally has.
This could do with some testing, but I believe the unsaved inner blocks are save upon editing now, and it seemed to work ok for me. It's questionable if the Disabled wrapper is also still needed, but I left it there.
I did spot some issues that are also present in trunk, like the way links added after page list are aligned to the right:
|
Size Change: -445 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When the
UnsavedInnerBlockscomponent is rendered, the block props are rendered twice in the navigation block.In this screenshot you can see the first and last elements have duplicated attributes
This PR should fix the issue.
Why?
This results in duplicated
idattributes on two DOM elements.How?
Stop passing
blockPropsthrough to theUnsavedInnerBlockscomponent.Once this prop was no longer present, the layout of the blocks was incorrect due to the intervening
wp-block-navigation__unsaved-changesandwp-block-navigation__unsaved-changes-overlayelementsTesting Instructions