Code Block: Fix duplicate background color #43599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +21 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
This is an improvement over trunk. |
carolinan
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #43587
What?
This PR fixes duplicate background color when padding and gradient backgrounds are set on code blocks.
Why?
This problem is caused by the fact that the background color of the code tag is inherited in the reset CSS.
How?
In the cover block editor style, I have set the background of the child code block to
none.Testing Instructions
Screenshots or screencast
On trunk
On this branch