Migrate writing flow tests to Playwright #43637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
changed the title
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
talldan and
kevin940726
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
I wonder if we can speed up similar tests, where we just add a bunch of blocks and only need a clean slate for the next test. Maybe we can introduce a new test.beforeAll( async ( { admin } ) => {
await admin.createNewPost();
} );
test.beforeEach( async ( { editor } ) => {
// Reset post content before each test.
await editor.clearPostContent();
} );It takes almost a minute to run this spec locally. |
kevin940726
reviewed
Aug 30, 2022
How do you imagine that to work? We intentionally don't want to re-use the same let postId;
test.beforeAll( async ( { admin, writingFlowUtils, editor } ) => {
await admin.createNewPost();
await writingFlowUtils.addDemoContent();
postId = await editor.publishPost();
} );
test.beforeEach( async ( { page } ) => {
await page.goto( `/wp-admin/post.php?post=${postId}&action=edit` );
} );As long as we don't save the post in the progress, we should get the same state across all tests. Will this solve the problem you mentioned? |
Thanks for refreshing my memory. Trying something like this is only worth it if we cut down the test run time. Probably too early to think about it. |
Mamaduka
force-pushed
the
migrate/writing-flow-tests
branch
from
a4798fd to
a977eea
Compare
kevin940726
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
LGTM 👍. Just some nitpicks left and #43637 (comment) we can try.
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Mamaduka
force-pushed
the
migrate/writing-flow-tests
branch
from
250f310 to
4b45e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Should solve #41396. 🤞
PR migrates the writing flow tests to Playwright.
Notes
should navigate empty paragraph(s),so I removed it.Testing Instructions