Lodash: Remove completely from @wordpress/i18n package
#43677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
swissspidy
approved these changes
Aug 29, 2022
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
| if ( ! isEmpty( comments ) ) { | ||
| if ( ! isEmpty( comments.reference ) ) { | ||
| if ( Object.values( comments ).length ) { | ||
| if ( comments.reference ) { |
There was a problem hiding this comment.
This now throws an error if comments is null or undefined
TypeError: Cannot convert undefined or null to object
There was a problem hiding this comment.
Nice catch. Fix suggested in #45414.
Test instructions to reproduce would be really helpful to ensure we fixed it properly @manzoorwanijk .
There was a problem hiding this comment.
Simply run npx pot-to-php path/to/translations.pot path/to/translations.php your-text-domain to see the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/i18npackage, including thelodashdependency altogether.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're dealing with straightforwardly replacing
isEmpty()against a predictable data structure, where sometimes it will be a string, and sometimes - an object.Testing Instructions
.potfile (or generate one).packages/i18n/tools/pot-to-php.js PATH_TO_POT foobar.phpstill works well and exports all translations to the provided PHP file.